Skip to content

Conversation

@bios62
Copy link
Contributor

@bios62 bios62 commented Oct 9, 2024

I have added a reusable assets for OCI IAM DSK Python SDK authentication. It is based on old Oracle By Example and the SDK download from the OCI IAM Domain console. But both these are outdated, old PY versions and old depreciated features of PY packages. The assets reflects update to Py 3.0 and the latest PY packages. With this asset we have a running example of how to use OAUTH and OCI IAM PY SDK for application authentication. If the customer stick to the most recent SDK example in the console and the OBE, it will fail.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 9, 2024
@bios62 bios62 requested a review from oheimburger October 10, 2024 06:16
Copy link
Member

@oheimburger oheimburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the scrren shot with the tokens includes PII data, you should drop this branch and create a new one with a sanitized screen shot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mask the tokens. They can contain PII data!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are fake, no real data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it easier to recognize as a redacted token.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include a verbatim copy of the OBE. Link to the OBE is good enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a new commit to the branch with the file removed and reference in README removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, There is a few issues. I create a new branch with the changes and submit it

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Oct 29, 2024
@ttscoff
Copy link
Contributor

ttscoff commented Oct 29, 2024

I'm working on adding an OCA agreement for the email I (accidentally) committed under, so this check will be passed as soon as that's approved. I can force a merge in the meantime if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it easier to recognize as a redacted token.

@ttscoff ttscoff merged commit 2bde679 into main Nov 4, 2024
1 check failed
@oheimburger oheimburger deleted the ios-iam-py-sdk branch November 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants